-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PartialDerivativeCoefficients
representation to lindiffops
#33
Add PartialDerivativeCoefficients
representation to lindiffops
#33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🙏🏻 Just some minor comments
c56c921
to
75e703c
Compare
It isn't used anywhere, and it's going to be very hard to integrate with the upcoming `PartialDerivativeCoefficients` refactor.
75e703c
to
3facb13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this 🙏🏻
One last comment: I think it would make sense to realize the multi-indices as a NumPy array with shape input_domain_shape
and dtype np.int_
. Let's discuss this offline.
Co-authored-by: Marvin Pförtner <[email protected]>
Turns out NumPy arrays are not hashable :D |
Added a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! 🙏🏻
Co-authored-by: Marvin Pförtner <[email protected]>
Each linear differential operator can be represented as a sum of partial derivatives, and this PR adds this representation to every lindiffop.
EDIT: Rework done